[GitHub] [flink] tsreaper commented on pull request #17634: [FLINK-24691][table-common] Fix precision for sum on decimal types

[GitBox]

tsreaper commented on pull request #17634:
URL: https://github.com/apache/flink/pull/17634#issuecomment-960550919


   Is it possible to add a test like
   ```python3
   for i in range(1, 39):
       for j in range(0, 39 - i):
           operand = '9' * i + '.' + '9' * j
           check_result('SELECT SUM(CAST(\'%s\' AS DECIMAL(%d, %d)))' % 
(operand, i, j), operand)
   ```
   
   so we can confirm that we've fixed the problem once and for all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org