matriv commented on pull request #17634: URL: https://github.com/apache/flink/pull/17634#issuecomment-960725346
@tsreaper Thx a lot for your review, Actually we decided to revert this change, so instead I've added comments that the LogicalTypeMerging doesn't follow 100% the Microsoft SQL server rules but instead a mixed approach adopted by Hive/Spark. So the fix for the SUM precision is made by adding an explicit cast in the implementation wrapping the `plus()` to preserve the precision/scale calculated separately for SUM and don't allow the addition rules to override it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
