Myasuka commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r742598674
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java
##########
@@ -46,18 +48,24 @@
class CheckpointSubsumeHelper {
private static final Logger LOG =
LoggerFactory.getLogger(CheckpointSubsumeHelper.class);
- public static void subsume(
+ @Nullable
+ public static CompletedCheckpoint subsume(
Deque<CompletedCheckpoint> checkpoints, int numRetain,
SubsumeAction subsumeAction)
throws Exception {
if (checkpoints.isEmpty() || checkpoints.size() <= numRetain) {
- return;
+ return null;
Review comment:
I see, I'll refactor API to use `Optional`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
