Myasuka commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r742598361
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java
##########
@@ -67,6 +75,7 @@ public static void subsume(
}
// Don't break out from the loop to subsume intermediate savepoints
}
+ return lastSubsumedCheckpoint;
Review comment:
@pnowojski , thanks for your review! Sorry for late reply due to recent
too busy internal work.
The reason I prefer the solution to return the checkpoint to subsume is that
we might not susbume checkpoint each time especially when we adding a complete
savepoint (see
[FLINK-21351](https://issues.apache.org/jira/browse/FLINK-21351)). Just use a
getter would lost such information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
