slinkydeveloper commented on a change in pull request #17522:
URL: https://github.com/apache/flink/pull/17522#discussion_r737456090



##########
File path: 
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/generated/GeneratedClass.java
##########
@@ -71,7 +71,7 @@ public T newInstance(ClassLoader classLoader) {
                     // Because Constructor.newInstance(Object... initargs), we 
need to load
                     // references into a new Object[], otherwise it cannot be 
compiled.
                     .newInstance(new Object[] {references});
-        } catch (Exception e) {
+        } catch (Throwable e) {

Review comment:
       Because `newInstance` can throw a 
[`LinkageError`](https://docs.oracle.com/javase/7/docs/api/java/lang/LinkageError.html),
 which is not subclass of `Throwable`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to