slinkydeveloper commented on a change in pull request #17522: URL: https://github.com/apache/flink/pull/17522#discussion_r737447015
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/utils/CastExecutor.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.data.utils; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.TableException; + +import javax.annotation.Nullable; + +/** + * Interface to model a function that performs the casting of a value from one type to another. + * + * <p>This interface is serializable in order to be embedded in the runtime codegen. + * + * @param <IN> Input internal type + * @param <OUT> Output internal type + */ +@Internal +@FunctionalInterface +public interface CastExecutor<IN, OUT> { + /** + * Cast the input value. The output is null only and only if the input is null. The method Review comment: I don't think we should, because `TRY_CAST` is the user interface. This interface is just a detailed explanation of how internally we need to implement the casting logic, and every new implementation should be compliant to such interface (that is, when porting to these new interfaces, we need to take care of this difference) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
