slinkydeveloper commented on a change in pull request #17522: URL: https://github.com/apache/flink/pull/17522#discussion_r732007560
########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/data/casting/CastExpression.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.data.casting; + +import org.apache.flink.table.types.logical.LogicalType; + +import java.util.Objects; + +/** Generated cast expression result. */ Review comment: Added some details. ########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/casting/CastRulePredicate.java ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.data.casting; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.LogicalTypeFamily; +import org.apache.flink.table.types.logical.LogicalTypeRoot; + +import javax.annotation.Nullable; + +import java.util.Collections; +import java.util.HashSet; +import java.util.Set; +import java.util.function.BiPredicate; + +/** + * In order to apply a {@link CastRule}, the runtime checks if a particular rule matches the tuple + * of input and target type using this class. In particular, a rule is applied if: + * + * <ol> + * <li>{@link #getTargetTypes()} includes the {@link LogicalTypeRoot} of target type and either + * <ol> + * <li>{@link #getInputTypes()} includes the {@link LogicalTypeRoot} of input type or + * <li>{@link #getInputTypeFamilies()} includes one of the {@link LogicalTypeFamily} of + * input type + * </ol> + * <li>Or {@link #getTargetTypeFamilies()} includes one of the {@link LogicalTypeFamily} of target + * type and either + * <ol> + * <li>{@link #getInputTypes()} includes the {@link LogicalTypeRoot} of input type or + * <li>{@link #getInputTypeFamilies()} includes one of the {@link LogicalTypeFamily} of + * input type + * </ol> + * <li>Or, if {@link #getCustomPredicate()} is not null, the input type and target type matches Review comment: I tried to clarify it a bit, check it out now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
