[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344345#comment-15344345 ]
ASF GitHub Bot commented on FLINK-1550: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68058143 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -149,6 +154,9 @@ class JobManager( var leaderSessionID: Option[UUID] = None + private var metricsRegistry : FlinkMetricRegistry = _ + private var jobManagerMetricGroup : JobManagerMetricGroup = _ --- End diff -- `null` values are discouraged in Scala. Better use `Option[FlinkMetricRegistry]` which you initialize with `None`. > Show JVM Metrics for JobManager > ------------------------------- > > Key: FLINK-1550 > URL: https://issues.apache.org/jira/browse/FLINK-1550 > Project: Flink > Issue Type: Sub-task > Components: JobManager, Metrics > Reporter: Robert Metzger > Assignee: Chesnay Schepler > Fix For: pre-apache > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)