PatrickRen opened a new pull request #17276:
URL: https://github.com/apache/flink/pull/17276


   
   ## What is the purpose of the change
   This pull request adds a configuration for KafkaSource for disabling offset 
commit on checkpoint, and add sanity checks on `group.id`
   
   
   ## Brief change log
   - Add config for disabling offset commit on checkpoint
   - Add sanity checks on `group.id`. If `group.id` is not specified, offset 
commit on checkpoint will be disabled
   - Remove auto-generated group id in Kafka table source
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added integration tests for using Kafka source without group ID
     - Added test validating KafkaSourceBuilder capturing corrupted 
configurations (enabled offset commit manually but missing group id)
     - Added test in Kafka table source for validating offset commit is 
disabled without group id
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to