dmvk commented on a change in pull request #17000:
URL: https://github.com/apache/flink/pull/17000#discussion_r702022088
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapTest.java
##########
@@ -386,59 +385,85 @@ public void
testApplicationIsStoppedWhenStoppingBootstrap() throws Exception {
bootstrap.stop();
- // we call the error handler
- assertException(errorHandlerFuture, CancellationException.class);
+ // we didn't call the error handler
+ assertFalse(errorHandlerFuture.isDone());
- // we return a future that is completed exceptionally
- assertException(shutdownFuture, CancellationException.class);
+ // shutdown future gets completed normally
+ shutdownFuture.get();
+
+ // verify that we didn't shut down the cluster
+ assertFalse(shutdownCalled.get());
// verify that the application task is being cancelled
assertThat(applicationExecutionFuture.isCancelled(), is(true));
+ assertThat(applicationExecutionFuture.isDone(), is(true));
}
@Test
- public void testErrorHandlerIsCalledWhenStoppingBootstrap() throws
Exception {
+ public void testClusterIsShutdownCalledWhenSubmissionThrowsAnException()
throws Exception {
Review comment:
Thanks, I've missed this one 👍 Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
