dmvk commented on a change in pull request #17000:
URL: https://github.com/apache/flink/pull/17000#discussion_r698821009



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -247,6 +247,14 @@ public ClusterInformation getClusterInformation() {
         }
     }
 
+    public List<CompletableFuture<ApplicationStatus>> 
getDispatcherShutdownFutures() {
+        synchronized (this) {
+            return dispatcherResourceManagerComponents.stream()
+                    .map(DispatcherResourceManagerComponent::getShutDownFuture)
+                    .collect(Collectors.toList());
+        }
+    }

Review comment:
       removed

##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -710,6 +710,12 @@ JobManagerRunner createJobManagerRunner(JobGraph jobGraph, 
long initializationTi
         return CompletableFuture.completedFuture(Acknowledge.get());
     }
 
+    @Override
+    public CompletableFuture<Acknowledge> 
shutDownClusterExceptionally(Throwable throwable) {

Review comment:
       removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to