yangjunhan commented on a change in pull request #16980:
URL: https://github.com/apache/flink/pull/16980#discussion_r696449877



##########
File path: 
flink-runtime-web/web-dashboard/src/app/share/common/monaco-editor/monaco-editor.component.ts
##########
@@ -74,7 +74,7 @@ export class MonacoEditorComponent implements AfterViewInit, 
OnDestroy {
 
   ngAfterViewInit() {
     if ((window as any).monaco) {
-      this.setupMonaco();
+      setTimeout(() => this.setupMonaco());

Review comment:
       Inside the method `setupMonaco()`, it tries to get the 
`elementRef.nativeElement` of monaco-editor component and create an editor 
instance based on it . However, the editor component is not rendered yet while 
expanding the table row on the page **job -> exceptions -> exception history**, 
so the creation of editor instance must be delayed to the next tick after its 
template container is properly rendered.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to