twalthr commented on a change in pull request #16980:
URL: https://github.com/apache/flink/pull/16980#discussion_r698223738



##########
File path: 
flink-runtime-web/web-dashboard/src/app/share/common/monaco-editor/monaco-editor.component.ts
##########
@@ -74,7 +74,7 @@ export class MonacoEditorComponent implements AfterViewInit, 
OnDestroy {
 
   ngAfterViewInit() {
     if ((window as any).monaco) {
-      this.setupMonaco();
+      setTimeout(() => this.setupMonaco());

Review comment:
       we should document such temporary solutions in code comments such that 
future readers know what's going on. could you add a comment to this line? I 
will merge it afterwards




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to