tillrohrmann commented on a change in pull request #16894:
URL: https://github.com/apache/flink/pull/16894#discussion_r692917816



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -446,9 +446,13 @@ private CleanupJobState handleJobManagerRunnerResult(
             JobManagerRunnerResult jobManagerRunnerResult, ExecutionType 
executionType) {
         if (jobManagerRunnerResult.isInitializationFailure()) {
             if (executionType == ExecutionType.RECOVERY) {
-                return jobManagerRunnerFailed(
-                        
jobManagerRunnerResult.getExecutionGraphInfo().getJobId(),
-                        jobManagerRunnerResult.getInitializationFailure());
+                if (jobManagerRunnerResult.isJobFinishing()) {
+                    return CleanupJobState.GLOBAL;

Review comment:
       I would refrain from adding a new `JobStatus.UNKNOWN` value because 
`JobStatus` is public evolving and exposed at many places. I agree that 
`FAILED` is not optimal but we should state in the exception message that we 
could not properly deduce the final state. Moreover, I hope that this can be 
fixed with FLINK-11813 properly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to