Aitozi commented on a change in pull request #16894:
URL: https://github.com/apache/flink/pull/16894#discussion_r692873731
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
##########
@@ -578,6 +579,45 @@ public void testFatalErrorIfRecoveredJobsCannotBeStarted()
throws Exception {
fatalErrorHandler.clearError();
}
+ /** Tests that the {@link Dispatcher} do not fail by {@link
JobFinishingException}. */
+ @Test
+ public void testNonFatalErrorWhenRecoveredJobFinishingException() throws
Exception {
Review comment:
I add another test case in
`org.apache.flink.runtime.jobmaster.JobMasterServiceLeadershipRunnerTest#testJobAlreadyDone`
I think this can cover the current case, what do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
