pnowojski commented on pull request #16744: URL: https://github.com/apache/flink/pull/16744#issuecomment-895040850
Ok, I see. I would still say it would be much better to fix those tests, as we would have correct tests and even more efficient timers firing. But I understand that if you have time constraints we could leave this for a future improvement. Going with this simple change in `ProcessingTimeServiceUtil.getProcessingTimeDelay()` would already improve performance by quite a bit. If you choose to go with this easier path can you: 1. create a ticket for the follow up performance improvement and test fix, with a detailed description what should be fixed and what's the problem? 2. add a todo comment in `ProcessingTimeServiceUtil.getProcessingTimeDelay()` and in `InternalTimerServiceImpl#onProcessingTime` pointing to this newly created ticket ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
