Jiayi-Liao edited a comment on pull request #16744:
URL: https://github.com/apache/flink/pull/16744#issuecomment-894593088


   @pnowojski  To make the change pass the CI, I have to modify 
`TestProcessingTimeService.setCurrentTime(long)` which may affect a lot of 
tests. (Try `InternalTimerServiceImplTest.testSnapshotAndRestorePreVersioned()` 
with this PR)
   
   And I tried to correct the related tests (see 
[commit](https://github.com/Jiayi-Liao/flink/commit/28021a31a832c977af76ac6fc97956d41ed90e53)),
 but failed because the influence seems to be too huge, especially there's also 
a parent class `AbstractStreamOperatorTestHarness` using the 
`TestProcessingTimeService.setCurrentTime(long)`. 
   
   Do you have any better solution for the problem?  If there's no better way, 
I would prefer the original solution I mentioned in 
[FLINK-23208](https://issues.apache.org/jira/browse/FLINK-23208) with a simple 
change in `ProcessingTimeServiceUtil.getProcessingTimeDelay()`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to