[GitHub] [flink] Zakelly commented on a change in pull request #16341: [FLINK-21804][state/changelog] Create and wire changelog storage with state backend

[GitBox]

Zakelly commented on a change in pull request #16341:
URL: https://github.com/apache/flink/pull/16341#discussion_r664417687



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -669,13 +677,18 @@ private void stopTaskExecutorServices() throws Exception {
                             taskInformation.getJobVertexId(),
                             tdd.getSubtaskIndex());
 
+            final StateChangelogStorage<?> changelogStorage =
+                    changelogStoragesManager.stateChangelogStorageForJob(
+                            jobId, jobInformation.getJobConfiguration());

Review comment:
       According to offline sync, we:
   - currently reads value from taskmanager configuration
   - pass value from user program and do overriding here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org