Zakelly commented on a change in pull request #16341:
URL: https://github.com/apache/flink/pull/16341#discussion_r664210116
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -669,13 +677,18 @@ private void stopTaskExecutorServices() throws Exception {
taskInformation.getJobVertexId(),
tdd.getSubtaskIndex());
+ final StateChangelogStorage<?> changelogStorage =
+ changelogStoragesManager.stateChangelogStorageForJob(
+ jobId, jobInformation.getJobConfiguration());
Review comment:
I agree that we could add a datastream API for
```STATE_CHANGE_LOG_STORAGE```. We could do this later when we have several
implementation of storage.
However, I prefer make another API instead of
```enableChangelogStateBackend("memory")```. It's not user-friendly to make
user know the storage shotcut name before using changelog, especially we may
have only one storage for production in most cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
