zentol commented on a change in pull request #16345:
URL: https://github.com/apache/flink/pull/16345#discussion_r662998718
##########
File path: flink-clients/pom.xml
##########
@@ -47,13 +47,13 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
-
<artifactId>flink-runtime_${scala.binary.version}</artifactId>
+ <artifactId>flink-runtime</artifactId>
Review comment:
ikr
##########
File path:
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcSystem.java
##########
@@ -51,6 +51,9 @@ RpcServiceBuilder remoteServiceBuilder(
@Nullable String externalAddress,
String externalPortRange);
+ /** Hook to cleanup resources, like common thread pools or classloaders. */
+ void cleanup();
Review comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
