zentol commented on a change in pull request #16345:
URL: https://github.com/apache/flink/pull/16345#discussion_r662997403
##########
File path:
flink-core/src/main/java/org/apache/flink/core/plugin/PluginLoader.java
##########
@@ -177,16 +177,16 @@ public P next() {
return resolveIfNeeded(resolve, loadedClass);
}
- if (isAllowedFlinkClass(name)) {
- try {
+ try {
Review comment:
If it doesnt contain o.a.f then it cant use stuff like Preconditions. Id
also prefer a separate CL, or a generic one flexible enough to allow certain
parent-first / child-first patterns while denying everything not listed in the
pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
