Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1941#discussion_r63702355
  
    --- Diff: 
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
 ---
    @@ -48,17 +49,53 @@
     /**
      * InputFormat to read data from a database and generate Rows.
      * The InputFormat has to be configured using the supplied 
InputFormatBuilder.
    - * 
    - * In order to query the JDBC source in parallel, you need to provide a 
parameterized
    - * query template (i.e. a valid {@link PreparedStatement}) and a {@link 
ParameterValuesProvider} 
    - * which provides binding values for the query parameters.
    - * 
    + * A valid RowTypeInfo must be properly configured in the builder, e.g.: 
</br>
    + *
    + * <pre><code>
    + * TypeInformation<?>[] fieldTypes = new TypeInformation<?>[] {
    + *         BasicTypeInfo.INT_TYPE_INFO,
    + *         BasicTypeInfo.STRING_TYPE_INFO,
    + *         BasicTypeInfo.STRING_TYPE_INFO,
    + *         BasicTypeInfo.DOUBLE_TYPE_INFO,
    + *         BasicTypeInfo.INT_TYPE_INFO
    + * };
    + *
    + * RowTypeInfo rowTypeInfo = new RowTypeInfo(fieldTypes);
    + *
    + * Serializable[][] queryParameters = new String[2][1];
    --- End diff --
    
    This should go into the next code block about parallel reading.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to