Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63161970
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -94,31 +94,106 @@ private void establishConnection() throws
SQLException, ClassNotFoundException {
dbConn = DriverManager.getConnection(dbURL, username,
password);
}
}
-
+
/**
* Adds a record to the prepared statement.
* <p>
* When this method is called, the output format is guaranteed to be
opened.
+ * </p>
*
- * WARNING: this may fail if the JDBC driver doesn't handle null
correctly and no column types specified in the SqlRow
+ * WARNING: this may fail when no column types specified (because a
best effort approach is attempted in order to
--- End diff --
This warning should also go into the JavaDocs of the `JdbcOutputFormat`
class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
