tweise commented on pull request #15924: URL: https://github.com/apache/flink/pull/15924#issuecomment-842848588
> @tweise , thanks for creating pull request for `HybridSource` basic implementation. IMO, `SwitchableSource` and `SwitchableSplitEnumerator` mentioned in FLIP-150 could be introduced here to control the switching behavior more appropriately and add switchable source more conveniently. Please see discussion on the mailing list. In short, I don't think it is reasonable to mandate special "Switchable" interfaces for a source to be used with HybridSource since many use cases don't benefit from it, including the most basic scenario with fixed start positions. >What's more, does `HybridSourceITCase` need to verify the switching between FileSource and KafkaSource? That might be better achieved with an end to end test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
