tweise commented on a change in pull request #15924:
URL: https://github.com/apache/flink/pull/15924#discussion_r633189734



##########
File path: 
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/CoordinatedSourceITCase.java
##########
@@ -39,6 +42,46 @@
 /** IT case for the {@link Source} with a coordinator. */
 public class CoordinatedSourceITCase extends AbstractTestBase {
 
+    /** Test with start position dynamically derived from previous enumerator 
state. */
+    @Test
+    public void testHybridSourceWithDynamicStartPosition() throws Exception {

Review comment:
       This will be moved to HybridSourceITCase

##########
File path: 
flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/src/FileSourceTextLinesITCase.java
##########
@@ -118,16 +121,37 @@ private void testBoundedTextFileSource(FailoverType 
failoverType) throws Excepti
         // default
         writeHiddenJunkFiles(testDir);
 
-        final FileSource<String> source =
+        final FileSource<String> fileSource =
+                FileSource.forRecordStreamFormat(new TextLineFormat(), 
Path.fromLocalFile(testDir))
+                        .build();
+        // directory doesn't matter; splits are supplied by converter
+        final FileSource<String> fileSource2 =
                 FileSource.forRecordStreamFormat(new TextLineFormat(), 
Path.fromLocalFile(testDir))
                         .build();
 
+        HybridSource.SourceChain<String, FileSourceSplit, 
PendingSplitsCheckpoint<FileSourceSplit>>

Review comment:
       This will be reverted - now in HybridSourceITCase




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to