[
https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279035#comment-15279035
]
ASF GitHub Bot commented on FLINK-3758:
---------------------------------------
GitHub user knaufk reopened a pull request:
https://github.com/apache/flink/pull/1979
[FLINK-3758] Add possibility to register accumulators in custom triggers
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knaufk/flink FLINK-3758
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1979.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1979
----
commit d093fdd6bd22382cde3ae202adfd6d407caac0e8
Author: Konstantin Knauf <konstantin.kn...@tngtech.com>
Date: 2016-05-03T20:45:48Z
Added getOrDefaultAccumulator to RuntimeContext
commit 8fc4d39bbb5c76a1b0cc0a4e93522e59fb2135bd
Author: Konstantin Knauf <konstantin.kn...@tngtech.com>
Date: 2016-05-03T20:46:17Z
Exposed getOrDefaultAccumulator in WindowContext
commit 08df4fb00a500f8a131b4364f94c264c0b51e6b8
Author: Konstantin Knauf <konstantin.kn...@tngtech.com>
Date: 2016-05-05T16:42:10Z
Added simple test for Accumulators in Triggers
----
> Add possibility to register accumulators in custom triggers
> -----------------------------------------------------------
>
> Key: FLINK-3758
> URL: https://issues.apache.org/jira/browse/FLINK-3758
> Project: Flink
> Issue Type: Improvement
> Reporter: Konstantin Knauf
> Assignee: Konstantin Knauf
> Priority: Minor
>
> For monitoring purposes it would be nice to be able to to use accumulators in
> custom trigger functions.
> Basically, the trigger context could just expose {{getAccumulator}} of
> {{RuntimeContext}} or does this create problems I am not aware of?
> Adding accumulators in a trigger function is more difficult, I think, but
> that's not really neccessary as the accummulator could just be added in some
> other upstream operator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
