[ 
https://issues.apache.org/jira/browse/FLINK-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310006#comment-15310006
 ] 

ASF GitHub Bot commented on FLINK-3758:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1979
  
    Sorry for chiming in late.
    
    I was wondering whether we actually need accumulators here, or what we 
should add is access to the metrics. Because the use case seems to be 
"monitoring", not "side aggregates".
    
    Admittedly, the accumulators were the means of choice for metrics up to 
now, but for the future (now that we are adding proper metrics), we may want to 
fix this.


> Add possibility to register accumulators in custom triggers
> -----------------------------------------------------------
>
>                 Key: FLINK-3758
>                 URL: https://issues.apache.org/jira/browse/FLINK-3758
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Konstantin Knauf
>            Assignee: Konstantin Knauf
>            Priority: Minor
>
> For monitoring purposes it would be nice to be able to to use accumulators in 
> custom trigger functions. 
> Basically, the trigger context could just expose {{getAccumulator}} of 
> {{RuntimeContext}} or does this create problems I am not aware of?
> Adding accumulators in a trigger function is more difficult, I think, but 
> that's not really neccessary as the accummulator could just be added in some 
> other upstream operator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to