YuvalItzchakov commented on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-814074061
> > @fsk119 OK, I figured it out. Since I abstracted away `createTableScanAfterPushdown` to the base class, I always returned `FlinkLogicalTableScan.create`. This can't happen since the inherting classes are in different phases, one in logical optimization phase and one in the logical rewrite phase. Thus, I need a LogicalTableScan for the former and a FlinkLogicalTableSourceScan for the latter. > > Pushed the fix. > > Please also revert the modification about the `TestValuesTableFactory` and other unrelated modification. Reverted not related changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
