[GitHub] [flink] YuvalItzchakov commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

[GitBox]

YuvalItzchakov commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-814002061


   @fsk119 A question about the implementation:
   
   ```
   if (result.getRemainingFilters().isEmpty() && unconvertedPredicates.length 
== 0) {
     call.transformTo(newScan);
   } else { .. }
   ```
   
   If there are no remaining filters, should we not still include the calc in 
the plan? Currently it's only pushing the scan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org