austince commented on a change in pull request #15348:
URL: https://github.com/apache/flink/pull/15348#discussion_r604231818
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java
##########
@@ -251,9 +282,8 @@ public void
testExecutionGraphGenerationWithAvailableResources() throws Exceptio
final int numAvailableSlots = 1;
- final OneShotLatch submitTaskLatch = new OneShotLatch();
- final TaskManagerGateway taskManagerGateway =
-
createWaitingForTaskSubmissionTaskManagerGateway(submitTaskLatch);
+ final SubmissionBufferingTaskManagerGateway taskManagerGateway =
+ new SubmissionBufferingTaskManagerGateway(numAvailableSlots);
Review comment:
The current test only waited for a single task to be submitted, even
though more were. For reactive mode, these did need to be updated in places.
I wanted to consolidate how we waited for task submission (between using a
OneShotLatch and a BlockingQueue) in this test suite, and the BlockingQueue
approach seemed more flexible and consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
