austince commented on a change in pull request #15348:
URL: https://github.com/apache/flink/pull/15348#discussion_r604233506
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java
##########
@@ -119,6 +123,21 @@
public static final TestExecutorResource<ScheduledExecutorService>
TEST_EXECUTOR_RESOURCE =
new
TestExecutorResource<>(Executors::newSingleThreadScheduledExecutor);
+ @Parameterized.Parameters(name = "execution mode = {0}")
+ public static Object[] data() {
+ return new Object[] {SchedulerExecutionMode.REACTIVE, null};
Review comment:
I considered that as well, though the core logic for requesting
resources and submitting graphs now depends on quite a bit on execution mode.
I'll review and see if there are cases where this can be reduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
