[GitHub] [flink] zicat commented on a change in pull request #15247: [FLINK-21833][Table SQL / Runtime] TemporalRowTimeJoinOperator.java will lead to the state expansion by short-life-cycle & huge RowData, although config idle.state.retention.time

[GitBox]

zicat commented on a change in pull request #15247:
URL: https://github.com/apache/flink/pull/15247#discussion_r603744434



##########
File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -209,6 +209,7 @@ public void onEventTime(InternalTimer<Object, 
VoidNamespace> timer) throws Excep
                 registerProcessingCleanupTimer();
             } else {
                 cleanupLastTimer();
+                nextLeftIndex.clear();

Review comment:
       When the program is going into line#211, that means leftState is empty 
and rightState is empty, so cleanupLastTimer() is to delete the cleanup trigger 
for this key. At this time, nextLeftIndexState is not 
empty(registeredTimerState is already cleanup because line#201), the 
nextLeftIndexState will be stored forever because cleanup trigger have been 
deleted.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org