[GitHub] [flink] zicat commented on a change in pull request #15247: [FLINK-21833][Table SQL / Runtime] TemporalRowTimeJoinOperator.java will lead to the state expansion by short-life-cycle & huge RowData, although config idle.state.retention.time

[GitBox]

zicat commented on a change in pull request #15247:
URL: https://github.com/apache/flink/pull/15247#discussion_r603014108



##########
File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -301,6 +302,8 @@ private void cleanupExpiredVersionInState(long 
currentWatermark, List<RowData> r
     public void cleanupState(long time) {
         leftState.clear();
         rightState.clear();
+        nextLeftIndex.clear();
+        registeredTimer.clear();

Review comment:
        Please let me know if there is anything I should change, thx 
@leonardBang 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org