AHeise commented on a change in pull request #15294:
URL: https://github.com/apache/flink/pull/15294#discussion_r602781363
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java
##########
@@ -871,13 +875,15 @@ public String toString() {
private final LongCounter lostCounter = new LongCounter();
private final LongCounter duplicatesCounter = new LongCounter();
private final IntCounter numFailures = new IntCounter();
+ private final Duration backpressureInterval;
private ListState<State> stateList;
protected transient State state;
protected final long minCheckpoints;
- protected boolean backpressure;
+ @Nullable private Deadline backpressureUntil;
- protected VerifyingSinkBase(long minCheckpoints) {
+ protected VerifyingSinkBase(long minCheckpoints, long
checkpointingInterval) {
this.minCheckpoints = minCheckpoints;
+ this.backpressureInterval =
Duration.ofMillis(checkpointingInterval);
Review comment:
Quite possible, but it's actually covering more this way (some tasks may
have data, other tasks don't) whereas we used to test only (every task has
data). It depends a bit on the run; so kind of randomized.
If you'd rather have more deterministic behavior, we could also set
backpressureInterval to `2 * checkpointingInterval`. Still a chance for
backpressure to be gone, but much rarer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
