AHeise commented on a change in pull request #15294:
URL: https://github.com/apache/flink/pull/15294#discussion_r602780900
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java
##########
@@ -343,7 +343,7 @@ public static DataType getDataType(AbstractEvent event,
boolean hasPriority) {
return EVENT_BUFFER;
}
CheckpointBarrier barrier = (CheckpointBarrier) event;
- if (barrier.getCheckpointOptions().needsAlignment()) {
+ if (barrier.getCheckpointOptions().isExactlyOnceMode()) {
Review comment:
A non-prioritized UC currently doesn't revoke credits. However, actually
the barrier now needs to be aligned, so I guess that change is bad.
Probably, it would be cleaner to encode the temporary non-UC UC behavior
into the `CheckpointOptions`. Maybe by transforming `isUnalignedCheckpoint`
into an enum `ALIGNED, UNALIGNED, TEMP_ALIGNED`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
