maosuhan commented on pull request #14376:
URL: https://github.com/apache/flink/pull/14376#issuecomment-806273548


   @wuchong Thanks for your opinion.
   1. Regarding your suggestion, should we use 
`connector.<field_name>.default_value="<default_value>"`? The field type must 
be array or map because only these 2 types do not tolerate null values in 
protobuf. The `<default_value>` only support simple type like 
int/string/float/enum etc. And if user do not set this param, we will use 
protobuf's default value.  
   2. I have a look at the 
`org.apache.flink.table.data.conversion.StructuredObjectConverter#generateCode` 
and the implementation is similar to my code. And I can use 
`org.apache.flink.table.runtime.generated.CompileUtils` to finish code 
compiling and classloading work.
   
   Does it sound good? @wuchong @libenchao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to