maosuhan commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-802704116
@libenchao Hi Benchao, very thanks for your review effort and it is a great appreciate that you give many detailed suggestions. I have fixed most of the issues and there's only 3 issues remaining that we should discuss. 1. should we use the user classloader to init protobuf class? 2. if flink row contains null value in complex type, shall we offer user a parameter to control whether the task should raise exception or fill in default values? I'm okay with that. 3. Regarding codegen framework, I'm trying to follow the way that flink itself does. Flink just concat piece of java codes together and I don't know if there's a better way to do this. I guess the main reason why the readability is not good is that java does not have text block function like scala has. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
