beyond1920 commented on a change in pull request #15003:
URL: https://github.com/apache/flink/pull/15003#discussion_r582798010
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/agg/WindowAggregateTest.scala
##########
@@ -683,4 +682,165 @@ class WindowAggregateTest extends TableTestBase {
"must be an integral multiple of step, but got maxSize 3600000 ms and
step 1500000 ms")
util.verifyExplain(sql)
}
+
+ @Test
Review comment:
I originally planned to add cases for cube and rollup. However I skip
them because they cannot translate to window aggregate, because there must
contain group key which does not contain window_start and window_end.
Do we need to add tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
