wuchong commented on a change in pull request #15003:
URL: https://github.com/apache/flink/pull/15003#discussion_r582675036



##########
File path: 
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/agg/WindowAggregateTest.scala
##########
@@ -683,4 +682,165 @@ class WindowAggregateTest extends TableTestBase {
       "must be an integral multiple of step, but got maxSize 3600000 ms and 
step 1500000 ms")
     util.verifyExplain(sql)
   }
+
+  @Test

Review comment:
       Could you add some tests for other grouping sets syntax, including 
`CUBE`, `ROLLUP`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to