wuchong commented on a change in pull request #14958:
URL: https://github.com/apache/flink/pull/14958#discussion_r582523520
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java
##########
@@ -286,7 +320,7 @@ public void testFailedBatchResult() {
@Test
public void testStreamingResult() {
- ResultDescriptor resultDescriptor = new ResultDescriptor("", schema,
true, true);
+ ResultDescriptor resultDescriptor = new ResultDescriptor("", schema,
true, true, false);
Review comment:
The last flag should be true.
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
##########
@@ -654,11 +654,7 @@ private void callSelect(SqlCommandCall cmdCall) {
if (resultDesc.isTableauMode()) {
try (CliTableauResultView tableauResultView =
new CliTableauResultView(terminal, executor, sessionId,
resultDesc)) {
- if (resultDesc.isMaterialized()) {
- tableauResultView.displayBatchResults();
- } else {
- tableauResultView.displayStreamResults();
- }
+ tableauResultView.displayResults(resultDesc.isStreamingMode());
Review comment:
The `CliTableauResultView` already holds the `resultDesc`, so there is
no need to pass the streaming mode again.
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
##########
@@ -654,11 +654,7 @@ private void callSelect(SqlCommandCall cmdCall) {
if (resultDesc.isTableauMode()) {
try (CliTableauResultView tableauResultView =
new CliTableauResultView(terminal, executor, sessionId,
resultDesc)) {
- if (resultDesc.isMaterialized()) {
- tableauResultView.displayBatchResults();
- } else {
- tableauResultView.displayStreamResults();
- }
+ tableauResultView.displayResults(resultDesc.isStreamingMode());
Review comment:
The `CliTableauResultView` already holds the `resultDesc`, so there is
no need to pass the streaming mode again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
