fsk119 commented on a change in pull request #14958:
URL: https://github.com/apache/flink/pull/14958#discussion_r581959473
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliChangelogResultView.java
##########
@@ -124,18 +125,11 @@ protected void refresh() {
stopRetrieval(false);
break;
default:
- List<Tuple2<Boolean, Row>> changes = result.getPayload();
+ List<Row> changes = result.getPayload();
- for (Tuple2<Boolean, Row> change : changes) {
+ for (Row change : changes) {
// convert row
- final String[] changeRow = new String[change.f1.getArity()
+ 1];
- final String[] row = PrintUtils.rowToString(change.f1);
- System.arraycopy(row, 0, changeRow, 1, row.length);
- if (change.f0) {
- changeRow[0] = "+";
- } else {
- changeRow[0] = "-";
- }
+ final String[] row = PrintUtils.rowToString(change,
NULL_COLUMN, true);
Review comment:
Sure. I will take it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
