Thesharing commented on a change in pull request #14868:
URL: https://github.com/apache/flink/pull/14868#discussion_r581008912
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/DistributionPattern.java
##########
@@ -18,29 +18,15 @@
package org.apache.flink.runtime.jobgraph;
-import org.apache.flink.runtime.executiongraph.ExecutionVertex;
-
/**
* A distribution pattern determines, which sub tasks of a producing task are
connected to which
* consuming sub tasks.
Review comment:
Added. I'm wondering would it be better to say "how ExecutionVertex and
IntermediateResultPartition is connected in {@link EdgeManagerBuildUtil}"?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/ConsumedPartitionGroup.java
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package org.apache.flink.runtime.scheduler.strategy;
+
+import org.apache.flink.runtime.jobgraph.IntermediateResultPartitionID;
+
+import java.util.Collections;
+import java.util.List;
+
+/** Group of consumed {@link IntermediateResultPartitionID}s. */
+public class ConsumedPartitionGroup {
+ private final List<IntermediateResultPartitionID> resultPartitions;
+
+ public ConsumedPartitionGroup(List<IntermediateResultPartitionID>
resultPartitions) {
+ this.resultPartitions = resultPartitions;
+ }
+
+ public ConsumedPartitionGroup(IntermediateResultPartitionID
resultPartition) {
+ this(Collections.singletonList(resultPartition));
+ }
+
+ public List<IntermediateResultPartitionID> getResultPartitions() {
+ return resultPartitions;
Review comment:
Agreed. Done.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/ConsumerVertexGroup.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package org.apache.flink.runtime.scheduler.strategy;
+
+import java.util.Collections;
+import java.util.List;
+
+/** Group of consumer {@link ExecutionVertexID}s. */
+public class ConsumerVertexGroup {
+ private final List<ExecutionVertexID> vertices;
+
+ public ConsumerVertexGroup(List<ExecutionVertexID> vertices) {
+ this.vertices = vertices;
+ }
+
+ public ConsumerVertexGroup(ExecutionVertexID vertex) {
+ this(Collections.singletonList(vertex));
+ }
+
+ public List<ExecutionVertexID> getVertices() {
+ return vertices;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
