wuchong commented on a change in pull request #14905:
URL: https://github.com/apache/flink/pull/14905#discussion_r580173180
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SliceAssigners.java
##########
@@ -321,20 +322,15 @@ public void mergeSlices(long sliceEnd, MergeCallback
callback) throws Exception
private static final long serialVersionUID = 1L;
private final int windowEndIndex;
- private final long windowSize;
+ private final SliceAssigner innerAssigner;
private final ReusableListIterable reuseExpiredList = new
ReusableListIterable();
- public WindowedSliceAssigner(int windowEndIndex, long windowSize) {
+ public WindowedSliceAssigner(int windowEndIndex, SliceAssigner
innerAssigner) {
Review comment:
It's a performance optimization. Using window end timestamp only, we can
reduce the overhead of serialization and deserialization, and reduce state
size, and higer mini-batch memory usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
