wuchong commented on a change in pull request #14905: URL: https://github.com/apache/flink/pull/14905#discussion_r580146816
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecWindowAggregate.java ########## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.nodes.exec.stream; + +import org.apache.flink.api.dag.Transformation; +import org.apache.flink.streaming.api.operators.OneInputStreamOperator; +import org.apache.flink.streaming.api.operators.SimpleOperatorFactory; +import org.apache.flink.streaming.api.transformations.OneInputTransformation; +import org.apache.flink.table.api.TableConfig; +import org.apache.flink.table.api.TableException; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.planner.calcite.FlinkRelBuilder.PlannerNamedWindowProperty; +import org.apache.flink.table.planner.codegen.CodeGeneratorContext; +import org.apache.flink.table.planner.codegen.agg.AggsHandlerCodeGenerator; +import org.apache.flink.table.planner.delegation.PlannerBase; +import org.apache.flink.table.planner.expressions.PlannerWindowProperty; +import org.apache.flink.table.planner.plan.logical.CumulativeWindowSpec; +import org.apache.flink.table.planner.plan.logical.HoppingWindowSpec; +import org.apache.flink.table.planner.plan.logical.TimeAttributeWindowingStrategy; +import org.apache.flink.table.planner.plan.logical.TumblingWindowSpec; +import org.apache.flink.table.planner.plan.logical.WindowAttachedWindowingStrategy; +import org.apache.flink.table.planner.plan.logical.WindowSpec; +import org.apache.flink.table.planner.plan.logical.WindowingStrategy; +import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNode; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase; +import org.apache.flink.table.planner.plan.nodes.exec.InputProperty; +import org.apache.flink.table.planner.plan.nodes.exec.utils.ExecNodeUtil; +import org.apache.flink.table.planner.plan.utils.AggregateInfoList; +import org.apache.flink.table.planner.plan.utils.AggregateUtil; +import org.apache.flink.table.planner.plan.utils.KeySelectorUtil; +import org.apache.flink.table.planner.utils.JavaScalaConversionUtil; +import org.apache.flink.table.runtime.generated.GeneratedNamespaceAggsHandleFunction; +import org.apache.flink.table.runtime.keyselector.RowDataKeySelector; +import org.apache.flink.table.runtime.operators.aggregate.window.SlicingWindowAggOperatorBuilder; +import org.apache.flink.table.runtime.operators.window.slicing.SliceAssigner; +import org.apache.flink.table.runtime.operators.window.slicing.SliceAssigners; +import org.apache.flink.table.runtime.operators.window.slicing.SliceSharedAssigner; +import org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; +import org.apache.flink.table.types.DataType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.RowType; + +import org.apache.calcite.rel.core.AggregateCall; +import org.apache.calcite.tools.RelBuilder; + +import java.time.Duration; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; + +/** + * Stream {@link ExecNode} for window table-valued based aggregate. + * + * <p>The differences between {@link StreamExecWindowAggregate} and {@link + * StreamExecGroupWindowAggregate} is that, this node is translated from window TVF syntax, but the + * other is from the legacy GROUP WINDOW FUNCTION syntax. In the long future, {@link + * StreamExecGroupWindowAggregate} will be dropped. + */ +public class StreamExecWindowAggregate extends ExecNodeBase<RowData> + implements StreamExecNode<RowData> { + + private static final long WINDOW_AGG_MEMORY_RATIO = 100; + + private final int[] grouping; + private final AggregateCall[] aggCalls; + private final WindowingStrategy windowing; + private final PlannerNamedWindowProperty[] namedWindowProperties; + + public StreamExecWindowAggregate( + int[] grouping, + AggregateCall[] aggCalls, + WindowingStrategy windowing, + PlannerNamedWindowProperty[] namedWindowProperties, + InputProperty inputProperty, + RowType outputType, + String description) { + super(Collections.singletonList(inputProperty), outputType, description); + this.grouping = grouping; + this.aggCalls = aggCalls; + this.windowing = windowing; + this.namedWindowProperties = namedWindowProperties; + } + + @SuppressWarnings("unchecked") + @Override + protected Transformation<RowData> translateToPlanInternal(PlannerBase planner) { + final ExecEdge inputEdge = getInputEdges().get(0); + final Transformation<RowData> inputTransform = + (Transformation<RowData>) inputEdge.translateToPlan(planner); + final RowType inputRowType = (RowType) inputEdge.getOutputType(); + + final TableConfig config = planner.getTableConfig(); + final SliceAssigner sliceAssigner = createSliceAssigner(windowing); + + // Hopping window requires additional COUNT(*) to determine whether to register next timer + // through whether the current fired window is empty, see SliceSharedWindowAggProcessor. + final boolean needInputCount = sliceAssigner instanceof SliceAssigners.HoppingSliceAssigner; Review comment: The COUNT(*) is used to know how much records in a window, similar to `RecordCounter` in `GroupAggFunction`. If the COUNT(*) of a window is `0`, then we don't need to register next timer for the hop window, otherwise, the timers for the hop window will grow unlimitly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
