tillrohrmann commented on a change in pull request #14904:
URL: https://github.com/apache/flink/pull/14904#discussion_r576064881
##########
File path:
flink-core/src/main/java/org/apache/flink/core/memory/HybridMemorySegment.java
##########
@@ -94,26 +126,22 @@
@Override
public void free() {
super.free();
+ if (cleaner != null) {
+ cleaner.run();
+ }
Review comment:
Ok, this sounds reasonable. Then let's do this refactoring soon. In
fact, `HeapMemorySegment` does not seem to be that unused anymore. Somehow the
table API started using this class for some `RawFormatDeserializationSchema`.
This might be a good indicator for pulling things straight.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
