xintongsong commented on pull request #14904: URL: https://github.com/apache/flink/pull/14904#issuecomment-778718163
@tillrohrmann Thanks for the review. Concerning indefinitely waiting when there's enough `expectedFreeMemory` but not enough `actualFreeMemory`, we have actually considered similar approach. I think this approach indeed solves the failures due to GC not releasing memory timely. However, it solves the problem by *waiting longer*, which may not have as good performance as the current solution that tries to *release earlier*. In case there's no enough heap activities to trigger GC in advance, we may frequently experience full GC on finishing existing tasks and deploying new tasks, which is costly for batch scenarios where deploying new tasks are frequent and TMs are usually large. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
