gaoyunhaii commented on a change in pull request #14734:
URL: https://github.com/apache/flink/pull/14734#discussion_r570169014



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -142,6 +145,7 @@ public PendingCheckpoint(
         this.checkpointId = checkpointId;
         this.checkpointTimestamp = checkpointTimestamp;
         this.notYetAcknowledgedTasks = checkNotNull(verticesToConfirm);
+        this.tasksToCommitTo = checkNotNull(tasksToCommitTo);

Review comment:
       I also more tend to store `CheckpointPlan` to `PendingCheckpoint`. We 
also do it in the second PR since there would be multiple collections to pass. 
I then change it in this PR and store `CheckpointPlan` in `PendingCheckpoint`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to