gaoyunhaii commented on a change in pull request #14734:
URL: https://github.com/apache/flink/pull/14734#discussion_r567825103



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1935,6 +1935,7 @@ private void abortPendingCheckpoint(
                 }
             } finally {
                 sendAbortedMessages(
+                        pendingCheckpoint.getTasksToCommitTo(),

Review comment:
       Based on current implementation `tasksToWaitFor` should be always 
equivalent to `tasksToCommitTo`. For me using `tasksToCommitTo` mainly comes 
from to keep the logic un-change, and also be symmetric with 
`sendCommitMessages`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to