zentol commented on pull request #14821: URL: https://github.com/apache/flink/pull/14821#issuecomment-770373198
This is insufficient. There is at least 1 code path in each application-cluster entry point class, where the execution is configured, which would not clean up the resources. Furthermore, given that the default `close()` implementation calls `closeAsync()` we can conclude that `closeAsync()` does not call `close()`. As such, the added code is unlikely to ever be executed because most(all?) components appear to work against `closeAsync()`. To top things off, if ClusterEntrypoint#startCluster fails we call `shutdownAsync()`, which never calls into `close[Async]()`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
