wangyang0918 commented on pull request #14630: URL: https://github.com/apache/flink/pull/14630#issuecomment-762308338
Actually, I am also confused about what is acceptable to keep in `docker-entrypoint.sh` and what is not. Maybe at the very begging we should not introduce the native K8s related logics to `docker-entrypoint.sh`. For how to implement kubernetes-specific features, I think we could have a dedicated entrypoint for native Kubernetes integration `kubernetes-entrypoint.sh`. After then, `docker-entrypoint.sh` is used only for standalone containerized deployment. Both `kubernetes-entrypoint.sh` and `docker-entrypoint.sh` could share some common functions(e.g. `copy_plugins_if_required `, `disable_jemalloc` , etc.). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
